Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix bug with reading dig strings #13083

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

larsoner
Copy link
Member

Closes #13079

I expect the code to work, but I still need a file locally to test. Not sure if it's worth adding a tiny one to the testing dataset. I might try using tmp_path and coding one quickly instead. Draft until I can at least verify it works.

Also I noticed some code dup in read_fiducials so I removed it, and hit a bug when using mne show_fiff where getformat isn't a method of csr_array so we can just report the class name instead in show_fiff.

@larsoner larsoner added the backport-candidate on-merge: backport to maint/1.9 label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate on-merge: backport to maint/1.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIFF_DIG_STRING kind data analysis
1 participant