-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More website fixes #9288
More website fixes #9288
Conversation
Here is the updated homepage, for reference: https://27181-1301584-gh.circle-artifacts.com/0/dev/index.html The size / alignment of the gallery images could use some tweaking. @larsoner feel free to push commits here if you want to experiment with getting the homepage the way you like it. |
you have a glitch in the footer
… |
Can we move the |
fixed: https://27238-1301584-gh.circle-artifacts.com/0/dev/index.html
not easily, I'm afraid. There is also now a second blocker (besides slower build time) that is keeping this as a draft PR: pydata/pydata-sphinx-theme#383 |
I mentioned this in #9289 but it belongs here: the TOC in the right column is broken, at least in https://27238-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/io/plot_20_reading_eeg_data.html - clicking on the various TOC entries highlights different sections. |
upstream issue: pydata/pydata-sphinx-theme#389 |
It seems to be the sphinx-gallery css that conflicts with the theme's css. Removing the rule for |
Thanks @jorisvandenbossche! I've followed up over at pydata/pydata-sphinx-theme#389 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drammock I think the spacing bug should be fixed by a recent SG PR, feel free to merge if you're happy with this
This PR:
doc/_static/copybutton.js
superseded bysphinx-copybutton
dependency)marking as draft because there are some questions about the latest theme version causing big slowdowns with the rendering process (pydata/pydata-sphinx-theme#381), and I want to see how bad they are for us before moving forward.