Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: observableset and observablemap notify all listeners when one is added with fireimmediately true #962

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Nov 24, 2023

Describe the changes proposed in this Pull Request.

If the PR fixes a specific issue, reference the issue with Fixes #.

Fixes #956


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for mobx canceled.

Name Link
🔨 Latest commit c9e74ad
🔍 Latest deploy log https://app.netlify.com/sites/mobx/deploys/65682c8c5cdadd000823bbd0

@amondnet amondnet self-assigned this Nov 24, 2023
@amondnet amondnet added the bug Something isn't working label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #962 (c9e74ad) into main (74e4a89) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   98.99%   99.00%           
=======================================
  Files          57       57           
  Lines        1998     2000    +2     
=======================================
+ Hits         1978     1980    +2     
  Misses         20       20           
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 98.55% <100.00%> (+<0.01%) ⬆️
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...src/api/observable_collections/observable_map.dart 100.00% <100.00%> (ø)
...src/api/observable_collections/observable_set.dart 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74e4a89...c9e74ad. Read the comment docs.

@amondnet amondnet force-pushed the 956-observableset-and-observablemap-notify-all-listeners-when-one-is-added-with-fireimmediately-true branch from dda6b5a to 46a7c26 Compare November 24, 2023 10:48
@amondnet amondnet marked this pull request as ready for review November 24, 2023 10:49
@amondnet amondnet added this to the mobx-2.2.2 milestone Nov 24, 2023
…ll-listeners-when-one-is-added-with-fireimmediately-true
@pavanpodila pavanpodila merged commit a00d4da into mobxjs:main Nov 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ObservableSet and ObservableMap notify all listeners when one is added with fireImmediately: true
2 participants