Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary observable notifications of Iterable or Map fields #964

Closed
wants to merge 5 commits into from

Conversation

amondnet
Copy link
Collaborator

@amondnet amondnet commented Dec 4, 2023

Describe the changes proposed in this Pull Request.

Following up on pr #844, perform deep equals if value is Iterable or Map.


Pull Request Checklist

  • If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • Increment the major/minor/patch/patch-count, depending on the complexity of change
  • Add the necessary unit tests to ensure the coverage does not drop
  • Update the Changelog to include all changes made in this PR, organized by version
  • Run the melos run set_version command from the root directory
  • Include the necessary reviewers for the PR
  • Update the docs if there are any API changes or additions to functionality

Copy link

netlify bot commented Dec 4, 2023

👷 Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5281253

@amondnet amondnet requested a review from pavanpodila December 4, 2023 04:58
@amondnet amondnet self-assigned this Dec 4, 2023
@amondnet amondnet closed this Dec 4, 2023
@amondnet amondnet removed the request for review from pavanpodila December 4, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant