-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds useDeepEquality
for creating observables
#971
Conversation
👷 Deploy request for mobx pending review.Visit the deploys page to approve it
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
==========================================
- Coverage 99.00% 98.90% -0.10%
==========================================
Files 57 57
Lines 2005 2006 +1
==========================================
- Hits 1985 1984 -1
- Misses 20 22 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
c6c72a3
to
1b3d722
Compare
useEquatable
for creating observablesuseDeepEquality
for creating observables
2faae45
to
1a7b0e3
Compare
Make the change in 2.2.3 optional. If you want the use this behavior , modify `@observable` to `@MakeObservable(useEquatable: true)`.
1a7b0e3
to
33c8881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the changes proposed in this Pull Request.
Make the change in 2.2.3 optional. If you want the use this behavior , modify
@observable
to@MakeObservable(useDeepEquality: true)
.Fixes #969
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelos run set_version
command from the root directory