-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add keepAlive to Computed #976
feat: add keepAlive to Computed #976
Conversation
✅ Deploy Preview for mobx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9c01892
to
4faf0f4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #976 +/- ##
=======================================
Coverage 99.00% 99.01%
=======================================
Files 57 57
Lines 2017 2024 +7
=======================================
+ Hits 1997 2004 +7
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
72276a3
to
863c9e2
Compare
Pls resolve the conflicts as we merged the previous PR that bumped the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall..need a version bump...also pls check if there is any drop in test coverage
863c9e2
to
cd4bf1a
Compare
cd4bf1a
to
4f3a787
Compare
@pavanpodila I rebased to the main branch and resolved the conflict. |
Describe the changes proposed in this Pull Request.
This avoids suspending computed values when they are not being observed by anything (see the above explanation). Can potentially create memory leaks.
Fixes #975
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelos run set_version
command from the root directory