Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cl.IsTakenOver and switch cl.isTakenOver to atomic.Bool #446

Merged
merged 4 commits into from
Jan 30, 2025
Merged

Add cl.IsTakenOver and switch cl.isTakenOver to atomic.Bool #446

merged 4 commits into from
Jan 30, 2025

Conversation

thedevop
Copy link
Collaborator

No description provided.

@thedevop thedevop requested a review from mochi-co January 17, 2025 03:06
@coveralls
Copy link

coveralls commented Jan 17, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13058259795

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 98.594%
Files with Coverage Reduction New Missed Lines %
server.go 2 99.19%
Totals Coverage Status
Change from base Build 13058244886: -0.03%
Covered Lines: 6171
Relevant Lines: 6259
💛 - Coveralls

@thedevop thedevop requested a review from werbenhu January 17, 2025 03:07
mochi-co
mochi-co approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@mochi-co mochi-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and makes sense to me 👍🏻

@mochi-co mochi-co merged commit 0439068 into mochi-mqtt:main Jan 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mochi-co mochi-co mochi-co approved these changes

@werbenhu werbenhu Awaiting requested review from werbenhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thedevop @coveralls @mochi-co