Refactor crafting item label and fix AppendWithSpace behavior

- Updated `AppendWithSpace` in `Item.cs`: - Corrected conditional logic to minimize nesting for clarity - Simplified maker's mark logic in `BaseArmor.cs`, `BaseClothing.cs`, and `BaseWeapon.cs`: - Removed redundant nested `if` blocks for better readability
modernuo · Jan 9, 2025 · 858f071 · 858f071
1 parent 758c6cd
commit 858f071
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 17 deletions.
diff --git a/Projects/Server/Items/Item.cs b/Projects/Server/Items/Item.cs
@@ -4128,9 +4128,10 @@ public static void AppendWithSpace(StringBuilder builder, string text)
     {
         if (!string.IsNullOrEmpty(text))
         {
-            if (builder.Length > 0) builder.Append(" ");
-            builder.Append(text);
+            return;
         }
+        if (builder.Length > 0) builder.Append(" ");
+        builder.Append(text);
     }
 
     public virtual void OnSingleClickPreAOS(Mobile from)

diff --git a/Projects/UOContent/Items/Armor/BaseArmor.cs b/Projects/UOContent/Items/Armor/BaseArmor.cs
@@ -1582,12 +1582,9 @@ public override void OnSingleClickPreAOS(Mobile from)
             }
 
             // Add maker's mark
-            if (PlayerConstructed)
+            if (PlayerConstructed && Crafter != null)
             {
-                if (Crafter != null)
-                {
-                    LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
-                }
+                LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
             }
         }
 

diff --git a/Projects/UOContent/Items/Clothing/BaseClothing.cs b/Projects/UOContent/Items/Clothing/BaseClothing.cs
@@ -958,12 +958,9 @@ public override void OnSingleClickPreAOS(Mobile from)
             }
 
             // Add maker's mark
-            if (PlayerConstructed)
+            if (PlayerConstructed && Crafter != null)
             {
-                if (Crafter != null)
-                {
-                    LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
-                }
+                LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
             }
         }
 

diff --git a/Projects/UOContent/Items/Weapons/BaseWeapon.cs b/Projects/UOContent/Items/Weapons/BaseWeapon.cs
@@ -3509,12 +3509,9 @@ public override void OnSingleClickPreAOS(Mobile from)
         }
 
         // Add maker's mark
-        if (PlayerConstructed)
+        if (PlayerConstructed && Crafter != null)
         {
-            if (Crafter != null)
-            {
-                LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
-            }
+            LabelTo(from, 1050043, Crafter.ToString()); // crafted by ~1_NAME~
         }
     }