Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added realAddress feature for container NAT networking #2043

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gshearer
Copy link

Added a runtime user configurable option "realAddress" -- if configured, MUO will tell the client to connect to this configured address if the client is coming from an IsPrivateNetwork() address.

This allows for container scenarios that are NAT'd as opposed to bridged, so that both local and outside clients can play simultaneously.

@kamronbatman
Copy link
Contributor

Thank you for submitting this. I believe this will work, but I am wondering if we should instead go another direction.

Currently we have all of the listeners, which by default would be all interfaces. I am wondering if it makes sense to get the IP range for each of those addresses, and if the connecting user is from one of those ranges, serve the IP from that listener. So for each listener, if the IP is within one of the private ranges, then we use that, otherwise if it is public, we serve the public address.

If someone containerizes or NATs using non-private networks, then we may want to look into amending/adding onto the network range using a config file (gateway-ip-ranges.json or whatever, I am making it up).

Let me know your thoughts on this approach since I believe it would algorithmically solve the issue without the need for an explicit prompt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants