Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of fixes for BlackMagicProbe #1152

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Couple of fixes for BlackMagicProbe #1152

merged 5 commits into from
Mar 26, 2024

Conversation

kapacuk
Copy link
Contributor

@kapacuk kapacuk commented Mar 26, 2024 •
edited by rleh
Loading

  • Added a missing import to modm_tools/bmp.py
  • Changed guess_serial_port() to use /dev/ttyBmpGdb when guessing a BMP port

rleh
rleh reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@rleh rleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kapacuk and welcome!

Thank you very much for your contribution. Looks fine, just two minor comments (see below).

tools/modm_tools/bmp.py Show resolved Hide resolved
tools/modm_tools/utils.py Show resolved Hide resolved
@rleh rleh added this to the 2024q1 milestone Mar 26, 2024
@rleh rleh requested a review from salkinium March 26, 2024 21:13
salkinium
salkinium approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@salkinium salkinium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! (Please squash into one commit.)

@salkinium salkinium merged commit d72efc7 into modm-io:develop Mar 26, 2024
12 checks passed
@salkinium
Copy link
Member

salkinium commented Mar 26, 2024 •
edited
Loading

Never mind, just remembered I can squash and merge from the GitHub UI. 🤦‍♂️

@kapacuk kapacuk deleted the fix/bmp_tools branch March 26, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleh rleh rleh approved these changes

@salkinium salkinium salkinium approved these changes

Assignees
No one assigned
Labels
enhancement 🌈 fix 💎 toolchain ⚙️
Milestone
2024q1
Development

Successfully merging this pull request may close these issues.
3 participants
@kapacuk @salkinium @rleh