Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scons] Fix duplicates in SConscript for external lbuild repos #1241

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

salkinium
Copy link
Member

SConscript files for external repos should not contain common code that's only necessary in the modm/SConscript repo file.

@salkinium salkinium added this to the 2024q4 milestone Dec 12, 2024
@salkinium salkinium marked this pull request as ready for review December 12, 2024 19:05
@salkinium salkinium force-pushed the fix/external_sconscript branch from f74a1eb to 7490d8e Compare December 12, 2024 20:37
@salkinium salkinium force-pushed the fix/external_sconscript branch from 7490d8e to 60eba38 Compare December 12, 2024 20:37
@salkinium salkinium merged commit 60eba38 into modm-io:develop Dec 13, 2024
12 checks passed
@salkinium salkinium deleted the fix/external_sconscript branch December 13, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant