add ar-usdz-max-texture-size (related google#4984 issue)

mohammadbaghaei · Jan 30, 2025 · 5763db9 · 5763db9
1 parent 51ff5d3
commit 5763db9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/packages/model-viewer/src/features/ar.ts b/packages/model-viewer/src/features/ar.ts
@@ -72,6 +72,7 @@ export declare interface ARInterface {
   arPlacement: string;
   iosSrc: string|null;
   xrEnvironment: boolean;
+  arUsdzMaxTextureSize: string;
   readonly canActivateAR: boolean;
   activateAR(): Promise<void>;
 }
@@ -83,6 +84,9 @@ export const ARMixin = <T extends Constructor<ModelViewerElementBase>>(
 
     @property({type: String, attribute: 'ar-scale'}) arScale: string = 'auto';
 
+    @property({type: String, attribute: 'ar-usdz-max-texture-size'})
+    arUsdzMaxTextureSize: string = 'auto';
+
     @property({type: String, attribute: 'ar-placement'})
     arPlacement: string = 'floor';
 
@@ -182,7 +186,8 @@ export const ARMixin = <T extends Constructor<ModelViewerElementBase>>(
       }
 
       if (changedProperties.has('ar') || changedProperties.has('arModes') ||
-          changedProperties.has('src') || changedProperties.has('iosSrc')) {
+          changedProperties.has('src') || changedProperties.has('iosSrc') ||
+          changedProperties.has('arUsdzMaxTextureSize')) {
         this[$selectARMode]();
       }
     }
@@ -446,7 +451,11 @@ configuration or device capabilities');
       model.position.copy(target.position);
       model.updateWorldMatrix(false, true);
 
-      const arraybuffer = await exporter.parseAsync(model);
+      const arraybuffer = await exporter.parseAsync(model, {
+        maxTextureSize: isNaN(this.arUsdzMaxTextureSize as any) ?
+            Infinity :
+            Math.max(parseInt(this.arUsdzMaxTextureSize), 16),
+      });
 
       model.position.set(0, 0, 0);
       target.add(model);

diff --git a/packages/modelviewer.dev/data/docs.json b/packages/modelviewer.dev/data/docs.json
@@ -355,6 +355,15 @@
           "<a href=\"../examples/augmentedreality/#ar\"><span class='attribute'>ios-src</span> example</a>"
         ]
       },
+      {
+        "name": "ar-usdz-max-texture-size",
+        "htmlName": "arUsdzMaxTextureSize",
+        "description": "Set texture max resolution for Quick Look auto generated USDZ model.",
+        "default": {
+          "default": "Infinity (no limits for maximum texture resolution)",
+          "options": "Number greater than or equal to 16"
+        }
+      },
       {
         "name": "xr-environment",
         "htmlName": "xrEnvironment",