Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panelapp gene query script added #10

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Panelapp gene query script added #10

merged 5 commits into from
Jun 24, 2024

Conversation

g-pyxl
Copy link
Contributor

@g-pyxl g-pyxl commented Jun 17, 2024

Simple script to generate CSV containing all current gene/panel relations using PanelApp API.
Updated README.


This change is Reviewable

Copy link
Contributor

@RachelDuffin RachelDuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to add a settings.json file - e.g. https://github.com/moka-guys/oncodeep_upload/blob/main/settings.json
This means the same formatting will be applied in vscode as in other existing team projects, to tidy up the scripts

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @g-pyxl)


okd_qc_commands.py line 11 at r1 (raw file):

Usage:
    python3 qcgen.py -p {dnanexus_project_id} -f {illumina_runfolder_name}

could you update the script name?


okd_qc_commands.py line 78 at r1 (raw file):

                # Write the FastQC command for each pair of fastq files
                script_file.write(

You could use f strings here, which can make the code easier to follow


okd_qc_commands.py line 133 at r1 (raw file):

    
    # Read the DNAnexus auth token from file
    auth_token = read_auth_token("/usr/local/src/mokaguys/.dnanexus_auth_token")

Suggestion to add this as a command line arg instead of the path to the secret


README.md line 73 at r1 (raw file):

### Usage:

python3 qcgen.py -p {dnanexus_project_id} -f {illumina_runfolder_name}

Could you update the script name here

Copy link
Contributor Author

@g-pyxl g-pyxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to repo.

Reviewable status: 1 of 6 files reviewed, 4 unresolved discussions (waiting on @RachelDuffin)


README.md line 73 at r1 (raw file):

Previously, RachelDuffin wrote…

Could you update the script name here

Done.


okd_qc_commands.py line 11 at r1 (raw file):

Previously, RachelDuffin wrote…

could you update the script name?

Done.


okd_qc_commands.py line 78 at r1 (raw file):

Previously, RachelDuffin wrote…

You could use f strings here, which can make the code easier to follow

Done, temporarily removing script until genomics server is live


okd_qc_commands.py line 133 at r1 (raw file):

Previously, RachelDuffin wrote…

Suggestion to add this as a command line arg instead of the path to the secret

Done, temporarily removing script until genomics server is live

Copy link
Contributor

@RachelDuffin RachelDuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r2.
Reviewable status: 5 of 6 files reviewed, all discussions resolved

Copy link
Contributor

@RachelDuffin RachelDuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 5 of 6 files reviewed, all discussions resolved

Copy link
Contributor

@RachelDuffin RachelDuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @g-pyxl)

@RachelDuffin RachelDuffin merged commit c8aecaa into main Jun 24, 2024
3 checks passed
@RachelDuffin RachelDuffin deleted the panelapp_gene_query branch June 24, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants