Make mongoose adapter compatible with mongoose 6, 7 and 8 #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icebob I'd love to have your review on this one if you've got some time to spare 🙏🏼 |
|
Changes look good, +1 for merge. |
|
@icebob can you review these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm recreating this PR as the preceding one has been automatically closed while resyncing my fork.
I've refactorized
connect()anddisconnect()methods from mongoose adapter to be compatible with mongoose 6, 7 and 8.I've checked that it worked properly by running the tests after installing each versions (6, 7, 8) of mongoose locally in the adapter repo.
I have tried to make tests run against mongoose 7 and 8 but it's a complete mess using old version of lerna.
I propose to merge it like that and add mongoose 7 and 8 tests once the npm workspaces refacto is done.