Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow links to accept onClick when used in asChild mode #388

Merged
merged 4 commits into from
Nov 16, 2023

Conversation

molefrog
Copy link
Owner

Also, I narrowed the type of children to be a valid React element.

@molefrog molefrog requested a review from jeetiss November 16, 2023 09:36
Copy link

codesandbox bot commented Nov 16, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
packages/wouter/esm/index.js 2.08 KB (0%)
packages/wouter/esm/use-browser-location.js 658 B (0%)
packages/wouter/esm/memory-location.js 836 B (0%)
packages/wouter/esm/use-hash-location.js 734 B (0%)
packages/wouter-preact/esm/index.js 1.97 KB (0%)
packages/wouter-preact/esm/use-browser-location.js 553 B (0%)
packages/wouter-preact/esm/use-hash-location.js 609 B (0%)
packages/wouter-preact/esm/memory-location.js 703 B (0%)

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91eabf4) 100.00% compared to head (0608eb6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #388   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jeetiss jeetiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@molefrog molefrog merged commit 57f7f8b into v3 Nov 16, 2023
4 checks passed
@molefrog molefrog deleted the fix/link-as-child-on-click branch November 16, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants