Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ entry: navigate outside component #390

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

GeorchW
Copy link

@GeorchW GeorchW commented Nov 30, 2023

As mentioned in #59 .

Btw, for me some VSCode extension (probably Markdown All in One) tries to update the table of contents to match the titles of the sections. I reverted these changes for now, but: is it intentional that they don't match?

Copy link

stackblitz bot commented Nov 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codesandbox bot commented Nov 30, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58f20e4) 100.00% compared to head (6b08df7) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #390   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          226       226           
  Branches        56        56           
=========================================
  Hits           226       226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molefrog
Copy link
Owner

molefrog commented Dec 2, 2023

Thank you!

I reverted these changes for now, but: is it intentional that they don't match?

This is def not intentional, could you push these changes as well so I can take a look?

Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am merging this, if you decide to fix the TOC, feel free to send another PR. Thank you!

@molefrog molefrog merged commit 15abefb into molefrog:main Dec 8, 2023
4 checks passed
@GeorchW GeorchW mentioned this pull request Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants