-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Types: Make LinkProps
return a proper type
#396
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #396 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
HookNavigationOptions
with type specsHookNavigationOptions
and make it work with empty options and arbitrary optionsUnfortunately,
ComponentProps<typeof Link>
will still not work, I don't have ideas how to fix this yet (it basically assumes thatHook
generic parameter isBaseLocationHook
and notBrowserLocationHook
, see skipped test case). Do you have any suggestions? Exported typeLinkProps
does work though.