-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tweak imports #441
chore: tweak imports #441
Conversation
…ents tree-shaking and removing makes code little bit smaller
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #441 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
I guess this should fix #435 as well |
Thank you. In #428 we added a hack to ensure that |
@molefrog yep, hack with but tree-shakability testing makes no sense to me now
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this anyway since it doesn't break anything, but might also fix the #435
remove destructuring assignment for react wildcard import because it prevents tree-shaking and removing makes code little bit smaller