Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoint structure change poc #736

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

Naoray
Copy link
Collaborator

@Naoray Naoray commented Jul 18, 2024

Should be self explanatory.

  • the exposed api is not changed (=devs wouldn't need to change anything).
  • endpoints can be grouped in one class (called EndpointCollection -> can be changed)
  • the individual requests define the resourceClass they are casted to when a response is returned.

IMO the BaseEndpointCollection is far from optimally structured, but after all it's a POC...

Atm those endpoints are implemented

$client = new MollieApiClient();
$client->setApiKey("test_xxxxxxxxxxxxxxxxxx");

$client->payments->page();
$client->payments->iterator();
$client->payments->get(..);
$client->payments->refund(..);
$client->paymentRefunds->page(..)

@Naoray Naoray requested a review from sandervanhooft July 18, 2024 15:14
@Naoray Naoray merged commit 6f004b8 into v3 Sep 6, 2024
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant