Fix hdfs diagnostic #544
Merged
Fix hdfs diagnostic #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In order to call calculateBuoyancyFlux2d() along with the ePBL the KPP fields are all allocated but not all are needed. This allocates only those used.
- The resetting/zeroing and accumulation of diagnostic arrays within
extractFluxes1d() assumes the routine is called only once. With the
need for a buoyancy flux in ePBL, it is currently being called twice.
- This was leading to the "hdfs" diagnostic accumulating too much.
- I have added a flag to indicate to not calculate the diagnostic fields.
- A better solution will be to only call once but calculate a buoyancy
flux in extractFluxes1d() but this will require more coding since
the latter is dependent on the equation of state and needs a different
interpretation of mass fluxes.
- I checked that this changes "hdfs" but have not checked whether other
diagnostics were affected.
- Closes NOAA-GFDL/MOM6-examples#128 but I opened #543 to make a note that
we have more tidying up to do.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- MOM_parameter_doc files updated by NOAA-GFDL/MOM6@7d401bc and NOAA-GFDL/MOM6@13541f4 - No answer changes. - NOAA-GFDL/MOM6@0192c3c Merge pull request mom-ocean#544 from adcroft/fix-hdfs-diagnostic - NOAA-GFDL/MOM6@e9f146d Merge pull request mom-ocean#542 from adcroft/replace-keyword-variable-name - NOAA-GFDL/MOM6@e05d8ae Merge pull request mom-ocean#541 from adcroft/fix-generic-tracer-MLD-arg - NOAA-GFDL/MOM6@13541f4 Merge pull request mom-ocean#540 from adcroft/mle-length-scale - NOAA-GFDL/MOM6@7d401bc Merge pull request mom-ocean#539 from adcroft/cleanup-varmix - NOAA-GFDL/MOM6@b56e593 Added "skip_diags" argument to extractFluxes1d() - NOAA-GFDL/MOM6@04116e8 Avoid allocating unused arrays in diabatic_driver - NOAA-GFDL/MOM6@0f28767 Replaced array-syntax with loops - NOAA-GFDL/MOM6@3eecc26 Replaced "sum" with "res" for variable name - NOAA-GFDL/MOM6@6e4eaa4 Fixed argument name to match declaration gen_trcr_col_physics() - NOAA-GFDL/MOM6@f733ff0 Implemented scale-aware option for MLE - NOAA-GFDL/MOM6@a110df9 Fix VarMix cleanup with openMP - NOAA-GFDL/MOM6@3e50273 Re-factor of MOM_lateral_mixing_coeffs.F90 (VarMix) - NOAA-GFDL/MOM6@a1ac57f Merge pull request mom-ocean#538 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM6@fec16b9 Renamed variables "mod" to "mdl" - NOAA-GFDL/MOM6@f6bade7 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM6@ebbce13 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directly resolves NOAA-GFDL/MOM6-examples#128 but is not the final solution as indicated in #543.
Two commits: