Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CXX-2745 relocate top-level dependencies into v1 headers #1318
base: master
Are you sure you want to change the base?
CXX-2745 relocate top-level dependencies into v1 headers #1318
Changes from 15 commits
41f5f2b
e65e63a
64097b4
2470ebb
b13118e
90dc075
d6ffdb9
ea6e914
1a9e26d
1a1a701
6f7a978
ba4797f
9f8b738
629d262
9096a30
87d2cab
7ffd8c2
df4fad9
0450683
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no
bsoncxx/
subdirectory underv1/
(e.g.bsoncxx/v1/bsoncxx/
) as there is no future plans to update or remove the existing include directory paths tobsoncxx/v_noabi/bsoncxx/
to support<bsoncxx/header.hpp>
(unstable ABI interfaces). Thev_noabi
headers will continue to provide root namespace redeclarations even after stable ABI interfaces are released and the ABI version number is made stable. Only users who need to maintain ABI stability requirements will need to include ABI-specific headers (e.g. following an API breaking change that updates redeclarations fromv1 -> v2
while preserving the ABI stability ofv1
symbols).