Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update RandomnessLotteryDemo TODOs #3139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: update RandomnessLotteryDemo TODOs #3139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/contracts/src/RandomnessLotteryDemo.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ contract RandomnessLotteryDemo is RandomnessConsumer {
/// @dev this limit based on the size of the request and the processing of the
/// @dev callback request in the fulfillRandomWords() function.
/// @dev The fee paid to start the lottery needs to be sufficient to pay for the gas limit
uint64 public FULFILLMENT_GAS_LIMIT = 100000; // TODO: fill XXX
uint64 public FULFILLMENT_GAS_LIMIT = 200000; // Safe gas limit for processing NUM_WINNERS random words and transferring rewards

/// @notice The minimum fee needed to start the lottery
/// @dev This does not guarantee that there will be enough fee to pay for the
Expand Down Expand Up @@ -188,7 +188,7 @@ contract RandomnessLotteryDemo is RandomnessConsumer {
/// We verify there is enough balance on the contract to pay for the deposit.
/// This would fail only if the deposit amount required is changed in the
/// Randomness Precompile.
uint256 requiredDeposit = 1000000000000000000; // TODO replace with RANDOMNESS_CONTRACT.requiredDeposit();
uint256 requiredDeposit = RANDOMNESS_CONTRACT.requiredDeposit();
if (address(this).balance < jackpot + requiredDeposit) {
revert DepositTooLow(
address(this).balance - jackpot,
Expand Down