Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix check-wasm-size #3154

Merged
merged 2 commits into from
Jan 24, 2025
Merged

chore(ci): fix check-wasm-size #3154

merged 2 commits into from
Jan 24, 2025

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 24, 2025

What does it do?

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

github-actions bot commented Jan 24, 2025

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2272 KB (no changes) ✅

Moonbeam runtime: 2252 KB (no changes) ✅

Moonriver runtime: 2244 KB (no changes) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2272 KB (+240 KB compared to latest release) ⚠️

Moonbeam runtime: 2252 KB (+240 KB compared to latest release) ⚠️

Moonriver runtime: 2244 KB (+232 KB compared to latest release) ⚠️

@RomarQ RomarQ added B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited) labels Jan 24, 2025
@RomarQ RomarQ self-assigned this Jan 24, 2025
@RomarQ RomarQ marked this pull request as ready for review January 24, 2025 17:20
@RomarQ RomarQ requested review from a team as code owners January 24, 2025 17:20
@RomarQ RomarQ requested review from pLabarta and stiiifff January 24, 2025 17:20
@RomarQ RomarQ merged commit aedf6b4 into master Jan 24, 2025
42 of 44 checks passed
@RomarQ RomarQ deleted the rq/fix-wasm-size-check branch January 24, 2025 17:36
Copy link
Contributor

Coverage Report

@@                    Coverage Diff                    @@
##           master   rq/fix-wasm-size-check     +/-   ##
=========================================================
  Coverage   74.58%                   74.58%   0.00%     
  Files         377                      377             
  Lines       96042                    96042             
=========================================================
  Hits        71632                    71632             
  Misses      24410                    24410             
Files Changed Coverage

Coverage generated Fri Jan 24 17:40:01 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B0-silent Changes should not be mentioned in any release notes D2-notlive PR doesn't change runtime code (so can't be audited)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants