Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pallet_moonbeam_foreign_assets benchmarks #3166

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RomarQ
Copy link
Contributor

@RomarQ RomarQ commented Jan 31, 2025

What does it do?

What important points should reviewers know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

Copy link
Contributor

WASM runtime size check:

Compared to target branch

Moonbase runtime: 2420 KB (no changes) 🚨

Moonbeam runtime: 2404 KB (no changes) 🚨

Moonriver runtime: 2392 KB (-8 KB) ✅

Compared to latest release (runtime-3401)

Moonbase runtime: 2420 KB (+388 KB compared to latest release) 🚨

Moonbeam runtime: 2404 KB (+392 KB compared to latest release) 🚨

Moonriver runtime: 2392 KB (+380 KB compared to latest release) ⚠️

Copy link
Contributor

Coverage Report

@@                               Coverage Diff                               @@
##           master   rq/update-moonbeam-foreign-assets-benchmarks     +/-   ##
===============================================================================
  Coverage   74.59%                                         74.59%   0.00%     
  Files         380                                            380             
  Lines       96029                                          96029             
===============================================================================
  Hits        71632                                          71632             
  Misses      24397                                          24397             
Files Changed Coverage

Coverage generated Fri Jan 31 17:14:03 UTC 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant