fix: unexpected memory limits option

[Lampese]

Related Issues

• Related issues: Unexpected memory limits option #556

Type of Pull Request

• Bug fix
• New feature
  • I have already discussed this feature with the maintainers.
• Refactor
• Performance optimization
• Documentation
• Other (please describe):

Does this PR change existing behavior?

• Yes (please describe the changes below)

  • ---

• No

Does this PR introduce new dependencies?

• No
• Yes (please check binary size changes)

Checklist:

• Tests added/updated for bug fixes or new features
• Compatible with Windows/Linux/macOS

[peter-jerry-ye-code-review]

‼️ This code review is generated by a bot. Please verify the content before trusting it.

Here are three observations from the provided git diff output:

1. Memory Limit Change:

   • The max value in memory-limits has been changed from 65536 to 65535 in moon.pkg.json. This change is also reflected in the test case (test_import_shared_memory). This could be intentional, but it's worth verifying if this change aligns with the intended behavior, as it reduces the maximum memory limit by 1. This might affect applications that rely on the previous limit.

2. Typo in Method Implementation:

   • In crates/moonutil/src/package.rs, the methods wasm_gc_memory_limits and wasm_gc_shared_memory were previously referencing self.link.as_ref()?.wasm.as_ref()?. This has been corrected to reference self.link.as_ref()?.wasm_gc.as_ref()?. This appears to be a bug fix, as the original code was likely referencing the wrong field (wasm instead of wasm_gc). This correction ensures the methods now correctly access the wasm_gc configuration.

3. Consistency in Test Case:

   • The test case test_import_shared_memory has been updated to reflect the change in the max memory limit from 65536 to 65535. This ensures that the test remains consistent with the updated configuration in moon.pkg.json. It's good practice to keep tests aligned with the actual configuration to avoid false positives or negatives during testing.

These changes seem to be intentional and correct, but it's always good to double-check the implications of reducing the memory limit and ensure that all dependent systems are compatible with the new value.

[Lampese]

cc @tonyfettes

[tonyfettes]

🤣