fix: Slightly change how locks are used. (#707)

CHANGELOG.md

@@ -18,7 +18,10 @@
 
 #### 🐞 Fixes
 
-- Fixed an issue where generating all the `~/.proto/bin` files for a tool may result in missing file warnings. Previously, we assumed that the exe locations from the resolved version would apply to all the versions being linked, but this isn't always true and isn't backwards compatible. We've now updated the bin linking to make a WASM API call for _each_ version being linked when locating exes, in hopes that this now finds the correct locations.
+- Fixed an issue where generating all the `~/.proto/bin` files for a tool may result in missing file warnings.
+  - Previously, we assumed that the exe locations from the resolved version would apply to all the versions being linked, but this isn't always true and isn't backwards compatible.
+  - We've now updated the bin linking to make a WASM API call for _each_ version being linked when locating exes, in hopes that this now finds the correct locations.
+- Fixed some directory unlocking issues.
 
 #### 🧩 Plugins
 

Cargo.toml

@@ -57,7 +57,7 @@ starbase_console = { version = "0.4.6", features = [
 starbase_sandbox = { version = "0.8.2" }
 starbase_shell = { version = "0.6.13", features = ["miette"] }
 starbase_styles = { version = "0.4.11" }
-starbase_utils = { version = "0.10.0", default-features = false, features = [
+starbase_utils = { version = "0.10.1", default-features = false, features = [
     "json",
     "miette",
     "net",

crates/core/src/flow/link.rs

@@ -79,7 +79,8 @@ impl Tool {
 
         // Only lock the directory and create shims if necessary
         if !to_create.is_empty() {
-            let _lock = fs::lock_directory(&self.proto.store.shims_dir)?;
+            // let _lock = fs::lock_directory(&self.proto.store.shims_dir)?;
+            fs::create_dir_all(&self.proto.store.shims_dir)?;
 
             for shim_path in to_create {
                 self.proto.store.create_shim(&shim_path)?;
@@ -155,7 +156,8 @@ impl Tool {
 
         // Only lock the directory and create bins if necessary
         if !to_create.is_empty() {
-            let _lock = fs::lock_directory(&self.proto.store.bin_dir)?;
+            // let _lock = fs::lock_directory(&self.proto.store.bin_dir)?;
+            fs::create_dir_all(&self.proto.store.bin_dir)?;
 
             for (input_path, output_path) in to_create {
                 debug!(

crates/core/src/proto.rs

@@ -88,7 +88,8 @@ impl ProtoEnvironment {
             let mut options = config.settings.http.clone();
             options.cache_dir = Some(self.store.cache_dir.join("requests"));
 
-            let mut loader = PluginLoader::new(&self.store.plugins_dir, &self.store.temp_dir);
+            let mut loader =
+                PluginLoader::new(&self.store.plugins_dir, self.store.temp_dir.join("plugins"));
             loader.set_client_options(&options);
             loader.set_offline_checker(is_offline);