Skip to content

Commit

Permalink
Prevents core removal for existing tags in most cases
Browse files Browse the repository at this point in the history
References #70 and #73. In many cases, the cores of tags that start uncivilized are removed by decisions and events that are meant to simulate historical change from uncivlized areas to colonies to post-colonial areas. However, if cores are considered to be claims, this should not occur while the tag still exists. This is different from a situation where tags give up cores in treaties, when this fix should not be applied. Additionally, I have allowed core removal in cases where the tag no longer exists, so that the simulation occurs as intended. I have ignored removal of ENG cores in the New World, since those should happen always through ENG giving up cores voluntarily. In other cases, especially within Europe, it seemed like a bad idea to change anything.

In the course of making changes, I removed `cleanup_colonial_cores`, since that decision should not exist if things function as intended.

I changed `organize_ghana` and `reorganize_ghana` to require a tag to own the in-game capital of Ashanti, since core removals were not working while Ashanti and other tags with claims on Ghana existed. This seemed justifiable to me since otherwise only a single coastal province was required to organize all of Ghana.

I removed a few apparently arbitrary Malay core changes in `97122`, `Anglo-Siamese Treaty of 1909`, because it did not make sense to switch around and not remove the claims of tags that do not exist. I additionally made some changes to add Malaysia cores properly to its provinces.

The initial set of changes succeeded with only a few noticed bugs. These and matters requiring investigation are listed and discussed [in this post](#70 (comment)).

Found an overlooked core removal of potentially existing Kurdish tags.

Acadia core removal now removes the cores on Maritime Union territory as well. Louisiana core removal now covers the possibility of USA core removal.
  • Loading branch information
rogerburks committed Feb 17, 2022
1 parent 47becfb commit 19bbaa5
Show file tree
Hide file tree
Showing 28 changed files with 5,351 additions and 1,466 deletions.
91 changes: 84 additions & 7 deletions ccHFM/decisions/BEL.txt
Original file line number Diff line number Diff line change
Expand Up @@ -507,13 +507,90 @@ political_decisions = {
1998 = { change_province_name = "Ango" life_rating = 25 }
1988 = { change_province_name = "Kolwezi" life_rating = 25 }
any_owned = { limit = { OR = { province_id = 1990 province_id = 1986 } } life_rating = 25 }
CNG = { all_core = { remove_core = KON } }
CNG = { all_core = { remove_core = KUB } }
CNG = { all_core = { remove_core = KZB } }
CNG = { all_core = { remove_core = LBA } }
CNG = { all_core = { remove_core = LUN } }
CNG = { all_core = { remove_core = AZA } }
CNG = { all_core = { remove_core = MNG } }
any_country = {
limit = {
tag = KON
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = KON
}
}
any_country = {
limit = {
tag = KUB
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = KUB
}
}
any_country = {
limit = {
tag = KZB
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = KZB
}
}
any_country = {
limit = {
tag = LBA
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = LBA
}
}
any_country = {
limit = {
tag = LUN
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = LUN
}
}
any_country = {
limit = {
tag = AZA
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = AZA
}
}
any_country = {
limit = {
tag = MNG
exists = no
}
all_core = {
limit = {
is_core = CNG
}
remove_core = MNG
}
}
}

ai_will_do = { factor = 1 }
Expand Down
27 changes: 23 additions & 4 deletions ccHFM/decisions/BoerWar.txt
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,29 @@ political_decisions = {
add_accepted_culture = boer
set_country_flag = post_colonial_country
}
any_owned = {
limit = { region = TRN_2108 }
remove_core = MAT
remove_core = GAZ
any_country = {
limit = {
tag = MAT
exists = no
}
all_core = {
limit = {
is_core = SAF
}
remove_core = MAT
}
}
any_country = {
limit = {
tag = GAZ
exists = no
}
all_core = {
limit = {
is_core = SAF
}
remove_core = GAZ
}
}
any_pop = {
limit = { location = { is_core = SAF } }
Expand Down
55 changes: 42 additions & 13 deletions ccHFM/decisions/CAN.txt
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,21 @@ political_decisions = {
capital = 65
small_arms = 50
regular_clothes = 50
CAN_60 = {
add_core = QUE
remove_core = RPL
}
2625 = {
add_core = QUE
remove_core = RPL
}
76 = {
add_core = QUE
remove_core = RPL
any_country = {
limit = {
tag = RPL
exists = no
}
all_core = {
limit = {
OR = {
province_id = 60
province_id = 2625
province_id = 76
}
}
remove_core = RPL
}
}
58 = { state_scope = { change_region_name = "Qu�bec" } }
}
Expand Down Expand Up @@ -112,8 +116,21 @@ political_decisions = {
CAN_13 = {
add_core = COL
add_core = CAN
remove_core = RPL
}
}
any_country = {
limit = {
tag = RPL
exists = no
}
all_core = {
limit = {
OR = {
province_id = 13
}
}
remove_core = RPL
}
}
#Remove RPL & USA Cores, if owned
RPL = {
any_owned = {
Expand All @@ -140,6 +157,18 @@ political_decisions = {
}
all_core = { remove_core = ENG }
}
any_country = {
limit = {
tag = RPL
exists = no
}
all_core = {
limit = {
is_core = COL
}
remove_core = RPL
}
}
}
ai_will_do = {
factor = 1
Expand Down
Loading

0 comments on commit 19bbaa5

Please sign in to comment.