Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References issue #95
In regular HFM, Hudson's Bay Company annexes into Canada in event
44321
, The Rupert's Land Act (Canada side). This happens even if Hudson's Bay Company is the player, without player protection or notification:ccHFM/ccHFM/events/CANFlavor.txt
Lines 1441 to 1449 in e0ee2ed
There are a few ways to address this. A player option to refuse could be added, with a Free Allied Cores casus belli awarded to UK, and it could be added later as Canadian flavor.
There was an American offer to purchase the territory controlled by the Company in 1869, but this seems to be a separate topic that is again best addressed as Canadian and/or American flavor.
A simpler alternative is to alter the event to switch the player's tag from Hudson's Bay Company to Canada in this event, and this is what I have chosen. This opens a route for starting as Hudson's Bay Company with the intent of playing onward as Canada. I have tested this as the player in Hudson's Bay, and by leaving it up to the a.i.
I have also moved the older handling of a.i. puppet Hudson's Bay (
RPL
) nearer to the bottom of theoption
, so that unintended problems can be avoided: it seems best to always have anything regarding annexation occur last or nearly so. Theoption
in core HFM is relatively complex, but it seems to already have provisions for handling an already independentRPL
.It remains possible, though difficult, to gain independence as
RPL
if rebels succeed and then the UK fails to puppet you again. As mentioned, expansion of this route would require creating a new event to ask RPL if it accepts or not. This sort of thing would probably be best done in a separate events file, with some other added flavor, to avoid cluttering core HFM files with new events.