Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier discovery of modern cavalry for westernized tags #108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogerburks
Copy link
Collaborator

@rogerburks rogerburks commented Jun 15, 2021

References #107

The 2% discovery rate for hussars (especially) seems draconian, especially considering that it is possible in-game to discover tanks and airplanes before discovering modern cavalry. This fix addresses the problem by making the discovery rate 100% for westernized tags that have military_staff_system. This seems appropriate since hussars may have historical origins as early as the late 14th century.

The operative part of the code to fix is here, adding a 98 modifier for westernized tags:

hussar_activation = {
limit = { military_staff_system = 1 }
chance = {
base = 2
modifier = {
factor = -2
not = { civilized = yes }
}
}
effect = {
activate_unit = hussar
}
}

Optionally, a there could be added a non-zero chance for non-westernized tags to discover them under certain reforms, but I have not added this.

The 2% discovery rate for hussars (especially) seems draconian, especially considering that it is possible to discover tanks and airplanes before discovering modern cavalry. This fix addresses that by making the discovery rate 100% for westernized tags. This seems appropriate since hussars may have historical origins as early as the late 14th century.

The operative part of the code to fix is here, adding a 98 modifier for westernized tags:

https://github.com/moretrim/ccHFM/blob/e9e6e9bad7e585acd1b082da13b73e0374f1d6e5/ccHFM/inventions/army_inventions.txt#L1202-L1214

Optionally, a there could be added a non-zero chance for non-westernized tags to discover them under certain reforms, but I have not added this.
@rogerburks rogerburks self-assigned this Jun 15, 2021
@rogerburks rogerburks requested a review from moretrim June 15, 2021 00:12
Copy link
Owner

@moretrim moretrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is good to go but I’m going to leave this open for some time. Reasons being:

  • this is a gameplay change relative to upstream, so I want to mark it as experimental
  • I have to go around implementing the preference system (2.0 quick list #112), to give player control over experimental features
  • that control means invention chances will have to be conditional

@moretrim moretrim added this to the 2.0 milestone Jul 19, 2021
@rogerburks rogerburks added the enhancement New feature or request label Feb 15, 2022
@rogerburks rogerburks linked an issue Feb 16, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easier discovery of modern cavalry for westernized tags
2 participants