Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

British Dominion release events are retuned to be less spammy #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rogerburks
Copy link
Collaborator

References #96

The decrease in dominion-release related event spam is accomplished through the addition of a blank country modifier that enforces a 1000-day cooldown. This cooldown agrees approximately with the time between historical British Colonial Conferences. If a dominion is released, the cooldown is not incurred. If release is refused, the cooldown is incurred.

This change was done because of the excessive amount of times that dominion release events repeat when Newfoundland is owned, most notoriously, but also for other held territories as well that are meant to be eventually released as British dominions. Additionally, the pressure to release dominions seemed to be misinterpreted by the code, which suggested that rebellions would otherwise soon occur. Instead, these events were more orderly historically, with real pressures but not incipient rebellion at the time of release.

Some of these events, especially Canadian, are retuned to take into account historical factors leading to the concept of British Dominions. Some militancy and consciousness effects of release refusal are toned down to be more realistic given the relatively orderly establishment of British dominions historically. Others are less modified, because I believe that once Canada had become a dominion, it made further dominions much more likely.

In the course of addressing the cited issue, I noticed that event 999100 "#Imperial Conference 1907" exists already. This suggests to me that, despite the titles, most dominion release events are meant to simulate cases where colonies were given self-rule due to the concept of responsible government. The switch to dominions occurs in 999100 for most.

@rogerburks rogerburks requested a review from moretrim February 15, 2022 23:09
@rogerburks rogerburks self-assigned this Feb 15, 2022
@rogerburks rogerburks added enhancement New feature or request bug Something isn't working labels Feb 15, 2022
@rogerburks rogerburks linked an issue Feb 16, 2022 that may be closed by this pull request
This is done through the addition of a blank country modifier that enforces a 3 year cooldown. This cooldown agrees approximately with the time between historical British Colonial Conferences. If a dominion is released, the cooldown is not incurred. If release is refused, the cooldown is incurred. Some of the events, especially Canadian, are retuned to take into account historical factors leading to the concept of British Dominions. Some militancy and consciousness effects of release refusal are toned down to be more realistic given the relatively orderly establishment of British dominions historically.

Added the French dominion events for Canada, Louisiana, and French New Zealand as well.
@rogerburks rogerburks force-pushed the rbx4/DominionRequestCooldown branch from 730fe16 to 7371519 Compare February 17, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UK dominions release spam
1 participant