British Dominion release events are retuned to be less spammy #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #96
The decrease in dominion-release related event spam is accomplished through the addition of a blank country modifier that enforces a 1000-day cooldown. This cooldown agrees approximately with the time between historical British Colonial Conferences. If a dominion is released, the cooldown is not incurred. If release is refused, the cooldown is incurred.
This change was done because of the excessive amount of times that dominion release events repeat when Newfoundland is owned, most notoriously, but also for other held territories as well that are meant to be eventually released as British dominions. Additionally, the pressure to release dominions seemed to be misinterpreted by the code, which suggested that rebellions would otherwise soon occur. Instead, these events were more orderly historically, with real pressures but not incipient rebellion at the time of release.
Some of these events, especially Canadian, are retuned to take into account historical factors leading to the concept of British Dominions. Some militancy and consciousness effects of release refusal are toned down to be more realistic given the relatively orderly establishment of British dominions historically. Others are less modified, because I believe that once Canada had become a dominion, it made further dominions much more likely.
In the course of addressing the cited issue, I noticed that event
999100
"#Imperial Conference 1907" exists already. This suggests to me that, despite the titles, most dominion release events are meant to simulate cases where colonies were given self-rule due to the concept of responsible government. The switch to dominions occurs in999100
for most.