Fixed a null pointer being passed to strcmp() in menus.c's ChangeMenu…

…Label() as identified by clang scan-build. Issue #48
morgant · Sep 1, 2024 · a267980 · a267980
1 parent 355d9ba
commit a267980
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/mlvwm/menus.c b/mlvwm/menus.c
@@ -1409,9 +1409,8 @@ void MapMenuBar( MlvwmWindow *win )
 void ChangeMenuLabel( MenuLabel *ml, char *newl, Icon *miniicon )
 {	
 	if( newl==NULL && ml->xpm==miniicon )	return;
-	if( ml->LabelStr && !strcmp(ml->LabelStr, newl )){
-		if( ml->LabelStr )
-			free( ml->LabelStr );
+	if(( ml->LabelStr && newl && !strcmp(ml->LabelStr, newl )) || (ml->LabelStr && !newl)) {
+		free( ml->LabelStr );
 		ml->LabelStr = newl;
 	}
 	ml->xpm = miniicon;