add option to disable mimic output to console (#215) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morsdyce
reviewed
Dec 11, 2019
| @@ -39,6 +39,16 @@ class SettingsSection extends React.Component { | |||
| Always show Mimic buttons | |||
| </label> | |||
| </SettingsBlock> | |||
| <SettingsBlock> | |||
| <label htmlFor="disable-output"> | |||
There was a problem hiding this comment.
Please use either Div or Span components from lib/ui/components/common/base.js
To avoid css leakage
There was a problem hiding this comment.
Sorry, I'm not very experienced with React.
Do you mean to replace <label htmlFor="disable-output"> with: <Div> or <Div htmlFor="disable-output">?
If yes, then the user won't be able to click the text to toggle the checkbox.
I used as an example the input above this one which also uses <label>(and we use <label> in more places in the ui in the same fashion).
Maybe we need to create a new Label component in lib/ui/components/common/base.js?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review.