Fix: Print correct file/line when a subroutine contains an assert. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests such as asserts were implemented as macros containing two parts:
snow_fail_update(); // Update the globally stored file and line number
_asserteq(thing 1, thing 2); // Perform a check
This falls down if "thing 1" or "thing 2" contain assertions themselves,
which themselves update the globally stored file and line number. If the
outer assertion then fails, it reports the wrong file and line number.
To fix this, add a struct _snow_explanation that is created in assertion
macros, and is used to update the global file and line number only once
the actual failiure is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests such as asserts were implemented as macros containing two parts:
This falls down if "thing 1" or "thing 2" contain assertions themselves, which themselves update the globally stored file and line number. If the outer assertion then fails, it reports the wrong file and line number.
To fix this, add a struct _snow_explanation that is created in assertion macros, and is used to update the global file and line number only once the actual failure is triggered.