-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Info Seller View #121
Open
ziadali22
wants to merge
12
commits into
develop
Choose a base branch
from
create-info-seller
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmdmhasn
reviewed
Sep 1, 2022
Comment on lines
15
to
17
@IBOutlet weak var shopImage: UIImageView! | ||
@IBOutlet weak var sortingButton: UIButton! | ||
@IBOutlet weak var followButton: UIButton! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
@IBOutlet weak var shopImage: UIImageView! | |
@IBOutlet weak var sortingButton: UIButton! | |
@IBOutlet weak var followButton: UIButton! | |
@IBOutlet private weak var shopImage: UIImageView! | |
@IBOutlet private weak var sortingButton: UIButton! | |
@IBOutlet private weak var followButton: UIButton! |
@@ -0,0 +1,21 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this image 7?
* create seller info cell nib. file * create cell extension model and configure function * solve uiImage problem * merge info seller and create collection view functionality * create seller info request and get data * Revert "Merge branch 'feat/add-seller-info-cell' of https://github.com/motoon-eg/dokan-store into feat/add-seller-info-cell" This reverts commit 9f69724, reversing changes made to 5a619c8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.