INTEGER to 64-bit native integer methods #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@v0-e and @mouse07410 After applying this pull request and changing all asn_INTEGER2ulong() in Open5GS to asn_INTEGER2uint64(), all S1AP/NGAP Test Programs in Open5GS work well on 32bit/64bit. Thank you so much! |
acetcom
added a commit
to open5gs/open5gs
that referenced
this pull request
Feb 12, 2024
APER encoding fails when using the asn_uint642INTEGER function on a 32-bit machine as shown below. ```C asn_uint642INTEGER(AMF_UE_NGAP_ID, 0xffffffff); ... aper_encode_to_buffer(...) ``` INTEGER APER encode/decode functions seem to be operating internally with long variables instead of intmax_t. That is probably the reason of the failure. @v0-e fixed this issues in the mouse07410/asn1c pull request. mouse07410/asn1c#176 mouse07410/asn1c#177
acetcom
added a commit
to open5gs/open5gs
that referenced
this pull request
Feb 12, 2024
APER encoding fails when using the asn_uint642INTEGER function on a 32-bit machine as shown below. ```C asn_uint642INTEGER(AMF_UE_NGAP_ID, 0xffffffff); ... aper_encode_to_buffer(...) ``` INTEGER APER encode/decode functions seem to be operating internally with long variables instead of intmax_t. That is probably the reason of the failure. @v0-e fixed this issues in the mouse07410/asn1c pull request. mouse07410/asn1c#176 mouse07410/asn1c#177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
INTEGER2int64()andINTEGER2uint64()functions, complementing the already implementedint642INTEGER()anduint642INTEGER().Also adds tests to test all of the mentioned functions.