Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix chomp depend, closes #3228 (backport #3229) #3230

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 12, 2025

Description

moveit_planners_chomp depends on chomp_motion_planner - both are needed - I missed that in #3015

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

This is an automatic backport of pull request #3229 done by [Mergify](https://mergify.com).

(cherry picked from commit 9e0b4dd)

# Conflicts:
#	moveit_planners/moveit_planners/package.xml
@mergify mergify bot added the conflicts label Jan 12, 2025
Copy link
Author

mergify bot commented Jan 12, 2025

Cherry-pick of 9e0b4dd has failed:

On branch mergify/bp/humble/pr-3229
Your branch is up to date with 'origin/humble'.

You are currently cherry-picking commit 9e0b4dd7a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   moveit_planners/moveit_planners/package.xml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@sea-bass sea-bass closed this Jan 12, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (51de436) to head (0b1bcaf).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           humble   #3230       +/-   ##
==========================================
- Coverage   51.41%       0   -51.40%     
==========================================
  Files         382       0      -382     
  Lines       31893       0    -31893     
==========================================
- Hits        16395       0    -16395     
+ Misses      15498       0    -15498     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass reopened this Jan 12, 2025
@sea-bass
Copy link
Contributor

I shouldn't have directly closed this, perhaps.

@mikeferguson Do you think we should uncomment these depends on Humble, or was there a reason it was still this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants