Label docker artifacts for easy removal and reference

[javiermtorres]

What's changing

This PR adds a label ai.mozilla.product_name=lumigator to volumes and containers for easy reference (mainly cleanup). Cleanup make targets use this label to delete the right containers and volumes.

Closes #757

How to test it

Using make clean-docker-containers should remove only Lumigator containers, no other containers that the user may have.

Additional notes for reviewers

N/A

I already...

• Tested the changes in a working environment to ensure they work as expected
• Added some tests for any new functionality
• Updated the documentation (both comments in code and product documentation under /docs)
• Checked if a (backend) DB migration step was required and included it if required
  • No DB changes

[agpituk]

Can't make it work currently @javiermtorres. I started from a clean slate , did a docker system prune -a then, using this branch, make start-lumigator. Then make stop-lumigator. Cleaning containers gives me the following errors afterwards:

➜  lumigator git:(javiermtorres/issue-757-label-docker-artifacts) ✗ make clean-docker-all 
RAY_WORKER_GPUS = 0
docker container prune --filter=ai.mozilla.product_name=lumigator



WARNING! This will remove all stopped containers.
Are you sure you want to continue? [y/N] y
Error response from daemon: invalid filter 'ai.mozilla.product_name'
make: *** [clean-docker-containers] Error 1
➜  lumigator git:(javiermtorres/issue-757-label-docker-artifacts) ✗ make clean-docker-containers
RAY_WORKER_GPUS = 0
docker container prune --filter=ai.mozilla.product_name=lumigator
WARNING! This will remove all stopped containers.
Are you sure you want to continue? [y/N] y
Error response from daemon: invalid filter 'ai.mozilla.product_name'
make: *** [clean-docker-containers] Error 1

Could it be that we need to do it like this? docker container prune --filter "label=ai.mozilla.product_name=lumigator"

[javiermtorres]

Could it be that we need to do it like this? docker container prune --filter "label=ai.mozilla.product_name=lumigator"

I maye have not pushed the latest state, let me check :-/

[javiermtorres]

I remember having checked the syntax, but somehow I didn't add it to the Makefile :-/ My apologies.