Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open …

…a new tab when custom homepage url is set (backport #24056) (#24058) Bugfix FXIOS-11009 - [Toolbar Redesign] One tap new tab doesn't open a new tab when custom homepage url is set (#24056) Open new tab when custom url is set. (cherry picked from commit 548c1af) Co-authored-by: PARAIPAN SORIN <[email protected]>
mozilla-mobile · Jan 13, 2025 · a19590e · a19590e · firefoxci-taskcluster · Jan 14, 2025
1 parent b536f3f
commit a19590e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift b/firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
@@ -4099,6 +4099,7 @@ extension BrowserViewController: TopTabsDelegate {
         let homePageURL = HomeButtonHomePageAccessors.getHomePage(profile.prefs)
 
         if shouldLoadCustomHomePage, let url = homePageURL {
+            openBlankNewTab(focusLocationField: false, isPrivate: isPrivate)
             tabManager.selectedTab?.loadRequest(PrivilegedRequest(url: url) as URLRequest)
         } else {
             openBlankNewTab(focusLocationField: true, isPrivate: isPrivate)

diff --git a/firefox-ios/Client/Frontend/Browser/PrivilegedRequest.swift b/firefox-ios/Client/Frontend/Browser/PrivilegedRequest.swift
@@ -25,7 +25,7 @@ private let REQUEST_KEY_PRIVILEGED = "privileged"
  PrivilegedRequest(), but the value of doing this is not clear as these requests should work fine
  as regular URLRequest().
  **/
-class PrivilegedRequest: NSMutableURLRequest {
+final class PrivilegedRequest: NSMutableURLRequest {
     override init(url: URL, cachePolicy: NSURLRequest.CachePolicy, timeoutInterval: TimeInterval) {
         func getUrl() -> URL {
             if InternalURL.isValid(url: url), let result = InternalURL.authorize(url: url) {