Refactor FXIOS-11076 [Swiftlint] Fix closure line length error in Boo…

…kmarksSaver.swift (#24158)
mozilla-mobile · Jan 15, 2025 · bd3d42b · bd3d42b
1 parent 76c8df4
commit bd3d42b
Showing 1 changed file with 53 additions and 47 deletions.
diff --git a/firefox-ios/Client/Frontend/Library/Bookmarks/Utitlity/BookmarksSaver.swift b/firefox-ios/Client/Frontend/Library/Bookmarks/Utitlity/BookmarksSaver.swift
@@ -29,54 +29,9 @@ struct DefaultBookmarksSaver: BookmarksSaver, BookmarksRefactorFeatureFlagProvid
             let operation: Deferred<Maybe<GUID?>>? = {
                 switch bookmark.type {
                 case .bookmark:
-                    guard let bookmark = bookmark as? BookmarkItemData else { return deferMaybe(nil) }
-
-                    if bookmark.parentGUID == nil {
-                        let position: UInt32? = parentFolderGUID == BookmarkRoots.MobileFolderGUID ? 0 : nil
-                        return profile.places.createBookmark(parentGUID: parentFolderGUID,
-                                                             url: bookmark.url,
-                                                             title: bookmark.title,
-                                                             position: position).bind { result in
-                            return result.isFailure ? deferMaybe(BookmarkDetailPanelError())
-                                                    : deferMaybe(result.successValue)
-                        }
-                    } else {
-                        let position: UInt32? = parentFolderGUID == bookmark.parentGUID ? bookmark.position : nil
-                        return profile.places.updateBookmarkNode(guid: bookmark.guid,
-                                                                 parentGUID: parentFolderGUID,
-                                                                 position: position,
-                                                                 title: bookmark.title,
-                                                                 url: bookmark.url).bind { result in
-                            return result.isFailure ? deferMaybe(BookmarkDetailPanelError()) : deferMaybe(nil)
-                        }
-                    }
-
+                    return saveBookmark(bookmark: bookmark, parentFolderGUID: parentFolderGUID)
                 case .folder:
-                    guard let folder = bookmark as? BookmarkFolderData else { return deferMaybe(nil) }
-
-                    if folder.parentGUID == nil {
-                        TelemetryWrapper.recordEvent(category: .action,
-                                                     method: .tap,
-                                                     object: .bookmark,
-                                                     value: .bookmarkAddFolder)
-
-                        let position: UInt32? = parentFolderGUID == BookmarkRoots.MobileFolderGUID ? 0 : nil
-                        return profile.places.createFolder(parentGUID: parentFolderGUID,
-                                                           title: folder.title,
-                                                           position: position).bind { result in
-                            return result.isFailure ? deferMaybe(BookmarkDetailPanelError())
-                                                    : deferMaybe(result.successValue)
-                        }
-                    } else {
-                        let position: UInt32? = parentFolderGUID == folder.parentGUID ? folder.position : nil
-                        return profile.places.updateBookmarkNode( guid: folder.guid,
-                                                                  parentGUID: parentFolderGUID,
-                                                                  position: position,
-                                                                  title: folder.title).bind { result in
-                            return result.isFailure ? deferMaybe(BookmarkDetailPanelError()) : deferMaybe(nil)
-                        }
-                    }
-
+                    return saveFolder(bookmark: bookmark, parentFolderGUID: parentFolderGUID)
                 default:
                     return nil
                 }
@@ -153,4 +108,55 @@ struct DefaultBookmarksSaver: BookmarksSaver, BookmarksRefactorFeatureFlagProvid
         let parentGuid = (isBookmarkRefactorEnabled ? recentBookmarkFolderGuid : nil) ?? BookmarkRoots.MobileFolderGUID
         _ = await save(bookmark: bookmarkData, parentFolderGUID: parentGuid)
     }
+
+    private func saveBookmark(bookmark: FxBookmarkNode, parentFolderGUID: String) -> Deferred<Maybe<GUID?>>? {
+        guard let bookmark = bookmark as? BookmarkItemData else { return deferMaybe(nil) }
+
+        if bookmark.parentGUID == nil {
+            let position: UInt32? = parentFolderGUID == BookmarkRoots.MobileFolderGUID ? 0 : nil
+            return profile.places.createBookmark(parentGUID: parentFolderGUID,
+                                                 url: bookmark.url,
+                                                 title: bookmark.title,
+                                                 position: position).bind { result in
+                return result.isFailure ? deferMaybe(BookmarkDetailPanelError())
+                                        : deferMaybe(result.successValue)
+            }
+        } else {
+            let position: UInt32? = parentFolderGUID == bookmark.parentGUID ? bookmark.position : nil
+            return profile.places.updateBookmarkNode(guid: bookmark.guid,
+                                                     parentGUID: parentFolderGUID,
+                                                     position: position,
+                                                     title: bookmark.title,
+                                                     url: bookmark.url).bind { result in
+                return result.isFailure ? deferMaybe(BookmarkDetailPanelError()) : deferMaybe(nil)
+            }
+        }
+    }
+
+    private func saveFolder(bookmark: FxBookmarkNode, parentFolderGUID: String) -> Deferred<Maybe<GUID?>>? {
+        guard let folder = bookmark as? BookmarkFolderData else { return deferMaybe(nil) }
+
+        if folder.parentGUID == nil {
+            TelemetryWrapper.recordEvent(category: .action,
+                                         method: .tap,
+                                         object: .bookmark,
+                                         value: .bookmarkAddFolder)
+
+            let position: UInt32? = parentFolderGUID == BookmarkRoots.MobileFolderGUID ? 0 : nil
+            return profile.places.createFolder(parentGUID: parentFolderGUID,
+                                               title: folder.title,
+                                               position: position).bind { result in
+                return result.isFailure ? deferMaybe(BookmarkDetailPanelError())
+                                        : deferMaybe(result.successValue)
+            }
+        } else {
+            let position: UInt32? = parentFolderGUID == folder.parentGUID ? folder.position : nil
+            return profile.places.updateBookmarkNode( guid: folder.guid,
+                                                      parentGUID: parentFolderGUID,
+                                                      position: position,
+                                                      title: folder.title).bind { result in
+                return result.isFailure ? deferMaybe(BookmarkDetailPanelError()) : deferMaybe(nil)
+            }
+        }
+    }
 }