Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-10814 - [Firefox Password Keychain] - Autofill from Firefox in any browser doesn't work #23953

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PARAIPAN9
Copy link
Collaborator

@PARAIPAN9 PARAIPAN9 commented Dec 24, 2024

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Updates doc comments.
  • Retry to autofill again if it fails.
  • Retry error message to notify the user.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.58%
📖 Edited 2 files
📖 Created 0 files

CredentialProvider.appex: Coverage: 20.9

File Coverage
CredentialProviderViewController.swift 0.0% ⚠️
CredentialProviderPresenter.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 0ea07dd

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This PR has been automatically marked as stale. Please leave any comment to keep this PR opened. It will be closed automatically if no further update occurs in the next 7 days. Thank you for your contributions!

@github-actions github-actions bot added the stale Stalebot use this label to stale issues and PRs label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stalebot use this label to stale issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants