Refactor MTE-3733 Use waitAndTap() throughout XCUITest and SyncIntegrationTests #24050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarmso
added
the
Do Not Merge ⛔️
Generated by 🚫 Danger Swift against ba9bea9 |
clarmso
commented
Jan 8, 2025
| @@ -70,11 +70,11 @@ class BaseTestCase: XCTestCase { | |||
| if icon.exists { | |||
| icon.press(forDuration: 1.5) | |||
| mozWaitForElementToExist(springboard.buttons["Remove App"]) | |||
There was a problem hiding this comment.
The mozWait can be removed.
clarmso
removed
the
Do Not Merge ⛔️
clarmso
changed the title
|
The size of this PR is quite large. Should I split this PR into smaller chunks? |
isabelrios
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
Experiment with
waitAndTap()throughoutXCUITests.Update: No regression detected. Let's do something to reduce future regression! 💪🏼 The failures are currently known.
https://storage.googleapis.com/mobile-reports/public/firefox-ios-M1/FullFunctionalTests/result_1307/build/reports/index.html
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)