Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe fix flatpak build checkout failures #10150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

oskirby
Copy link
Collaborator

@oskirby oskirby commented Dec 23, 2024

Description

I have noticed a lot of Flatpak build failures lately, which seem to end with a failure to checkout the Mozilla VPN sources, but the build never seems to fail on the main branch. I suspect that this is due to an inability to find the merge commit SHA in whatever build worker is running the build. We might have better luck using github.event.pull_request.head.sha instead, which is the latest commit on the PR branch rather than the merge commit.

Reference

i.e Jira or Github issue URL

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

@oskirby oskirby marked this pull request as ready for review December 30, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant