Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPN-6681 part 2: iOS and Android launch screens, Debug menu to show all images #10178

Open
wants to merge 5 commits into
base: vpn-6681-dark-mode-images
Choose a base branch
from

Conversation

mcleinman
Copy link
Collaborator

Description

Finishing touches for asset-related dark mode work:

  • Android and iOS now have launch screens that respect the system's color scheme. Important: This follows the system's dark mode/light mode, not our app's theming. (We cannot follow app theming, as launch screen is setup happens before app is fully open. Additionally, following the system's color mode preference makes sense for the launch screen, which is seen in the transition from the system to the app.) One consequence of this: This goes live immediately, and isn't behind a feature flag.
  • The new debug option for an image playground now works - it shows a chosen image 4 times - against both light and dark background, and both backgrounds have the light and dark version of the image.
  • The animation playground has been updated so the user can select one of several colors to use as the background.

Reference

VPN-6681

Checklist

  • My code follows the style guidelines for this project
  • I have not added any packages that contain high risk or unknown licenses (GPL, LGPL, MPL, etc. consult with DevOps if in question)
  • I have performed a self review of my own code
  • I have commented my code PARTICULARLY in hard to understand areas
  • I have added thorough tests where needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant