ci: split 'beetmover-apt' into promote and ship tasks #9638
Conversation
We want to have two tasks, one for promote and one for ship. The bucket / scopes that gets used should depend only on which of these tasks is running, and the tasks should then get filtered out at the target phase. We also remove the 'filter_shipping' transforms because these tasks will get filtered at the target phase. The generation (aka full) phase doesn't need to be doing any pre-filtering of its own.
There was a problem hiding this comment.
This is fine, but one thing I noticed while sanity checking is that we end up with two attributes for shipping phase:
beetmover-apt-promote-linux64-deb:
attributes:
always_target: false
kind: beetmover-apt
primary-kind-dependency: beetmover-promote
run_on_projects:
- all
run_on_tasks_for:
- action
shipping-phase: promote-client
shipping_phase: null
Elsewhere (eg: this Firefox release promotion action) we only have the underscore version in attributes. We should probably adjust this repo to only use the underscore version in attributes at some point, but it ought not to block this work.
Yeah I noticed that too, the underscore version gets added by the I agree we should switch to underscore.. it'll require a major bump to |
|
I have a feeling the "Add landing label" job is failing because it's coming from a fork. The error suggests the |
Description
We want to have two tasks, one for promote and one for ship. The bucket / scopes that gets used should depend only on which of these tasks is running, and the tasks should then get filtered out at the target phase.
We also remove the 'filter_shipping' transforms because these tasks will get filtered at the target phase. The generation (aka full) phase doesn't need to be doing any pre-filtering of its own.
Checklist