Rename to kinto-core #703
Rename to kinto-core #703
Conversation
... or kinto-core, Kinto-core, or KINTO_CORE as necessary. This doesn't change the use of "cliquet" in the documentation where it describes a mechanical object. There is also one place in the "hello" view where it seems like cliquet is being kept as a backwards-compatibility hack; I didn't change it there either.
Reformat everything to try to fix flake8 errors.
I'm not sure about this, but it seems like it's necessary to make the tests pass.
This isn't great, but hopefully it gets the point across.
|
Based on #687 (comment), I have also pushed 69c8760. It obviously looks very strange, but maybe it's correct? |
|
I think you should replace cliquet with kinto in there. |
| 'cliquet.initialization.setup_statsd', | ||
| 'cliquet.initialization.setup_listeners', | ||
| 'cliquet.events.setup_transaction_hook', | ||
| 'kinto_core.initialization.setup_request_bound_data', |
There was a problem hiding this comment.
I think all this should be kinto rather than kinto_core or cliquet
There was a problem hiding this comment.
These are python paths, not setting names
|
OK, so I've been looking at the history of the code and I'm more confused than ever. First, N.B. that we expose a We have to release a major version update anyhow, so I think breaking compatibility is OK. I'd even vote for getting rid of the hack entirely, but that might be outside the scope of this PR. If we can't do that, then I'm OK with either changing it or not changing it. |
|
The work about that is happening here: glasserc/kinto#1 |
This PR represents the first step in addressing #687. It's basically a giant search-and-replace for the string "cliquet".
The badges in README.rst and links to related tools like Travis and Coveralls remain with the old name until we have them set up under the new name. The changelog also uses the name Cliquet to refer to versions before the rename.
I'm especially soliciting feedback for 60f3514.
r? @almet @Natim @leplatrem