Add npm dependencies in the production image #23037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15314
Fixes: mozilla/addons#15315
Description
This stops the bleeding but we will need a better test for the production image that does not rely on mounted data.
Context
After moving node_modules to no longer be a dependency of /deps we need to explcitly copy both directories to the final production stage.
This was not caught so far because our CI checks are using make up which re-runs the build steps ensuring those files exist in the mount. We should run without a mount the same checks to verify the pure production image.
https://mozilla.sentry.io/issues/6254859352/?project=6224627&referrer=slack
Testing
You can run the build locally and inspect the files.. you cannot use make up for this because it mounts the files.
Checklist
#ISSUENUM
at the top of your PR to an existing open issue in the mozilla/addons repository.