Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an autonag to need-info when a bug is pending sec-approval but not all Tracking Flags are set. #2336

Open
DonalMe opened this issue Feb 5, 2024 · 3 comments · May be fixed by #2509
Open

Add an autonag to need-info when a bug is pending sec-approval but not all Tracking Flags are set. #2336

DonalMe opened this issue Feb 5, 2024 · 3 comments · May be fixed by #2509
Assignees
@suhaibmujahid @benjaminmah

Comments

@DonalMe
Copy link

DonalMe commented Feb 5, 2024

IF a Bug has an attachment that is pending sec-approval AND not all release tracking fields are set to affected/unaffected THEN create a need-info for the assignee to update the tracking flags status appropriately.

:{{ nickname }}, there is a patch pending security approval, however, the affected/unaffected status is not set for all current releases. Please update the status flags to correctly reflect the correct status.

NOTE: Please ensure bugbot doesn’t race against itself, this should only run after the flag automation has run. We don't want to add this prompt if there the regressed by has a bug and bugbot would automatically update the status flags anyway.
@DonalMe
Copy link
Author

DonalMe commented Feb 5, 2024

Please let me know if you need more details to triage/prioritize this correctly

@DonalMe
Copy link
Author

DonalMe commented Feb 7, 2024

Adding an extra detail - if possible can there be a grace period before the bot added the needinfo?
Avoid the scenario of someone adding the sec-approval request and then the bot pinging before they have time to update the release status. The sec-approval and release flags updates can't be updated at the same time.

@suhaibmujahid
Copy link
Member

if possible can there be a grace period before the bot added the needinfo?

Yes, this is doable.

@suhaibmujahid suhaibmujahid self-assigned this Feb 21, 2024
@benjaminmah benjaminmah linked a pull request Oct 17, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@suhaibmujahid suhaibmujahid

@benjaminmah benjaminmah

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@suhaibmujahid @DonalMe @benjaminmah