-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Rule] Needinfo when a bug is pending sec-approval but not all tracking flags are set #2509
base: master
Are you sure you want to change the base?
Conversation
Still a WIP: have not added the command to search for all open bugs with |
params = { | ||
"include_fields": self.fields, | ||
"resolution": "---", | ||
"f1": self.status, | ||
"o1": "anywords", | ||
"n1": "1", | ||
"v1": ",".join(["unaffected", "affected"]), | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query seems to retrieve all open bugs with tracking for the target version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, however I noticed that bugs may have multiple versions being tracked. Is there an easy way to view all versions and their statuses aside from iterating through all versions and manually checking in the query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
view all versions
Yes, you can return them all using the alias _custom
, but you cannot query them all with that alias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on this? How would I be able to use the alias?
but you cannot query them all with that alias.
Does this mean it is not possible to query all current release tracking fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot use the _custom
alias to query. It can be used to specify the fields that you want to return.
Here is an example where you could use other aliases to query without specifying the exact version, instead you specify the release channel:
bugbot/bugbot/rules/regression_new_set_nightly_affected.py
Lines 34 to 42 in 8ede0c2
"f4": "cf_status_firefox_nightly", | |
"o4": "equals", | |
"v4": "---", | |
"f5": "cf_status_firefox_beta", | |
"o5": "equals", | |
"v5": "---", | |
"f6": "cf_status_firefox_release", | |
"o6": "equals", | |
"v6": "---", |
4ea76b4
to
fb9eaf4
Compare
Resolves #2336.
Intended to needinfo bug assignees when not all current release tracking fields are set to either affected/unaffected and an attachment is pending
sec-approval
.Checklist
to-be-announced
tag added if this is worth announcing