Copy-duplicat-info - Avoid to nag forever because a bug hasn't a cf_crash_signature field #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rash_signature field
marco-c
reviewed
Nov 22, 2021
| @@ -117,6 +117,10 @@ def compare(self, bugs, dups): | |||
|
|
|||
| dup = dups[dupid] | |||
| bs = utils.get_signatures(info["signature"]) | |||
| if dup["signature"] is None: | |||
| # some bugs don't have a cf_crash_signature field... it's weird | |||
There was a problem hiding this comment.
Did you ask dkl about this?
There was a problem hiding this comment.
yes in #bmo on slack.
There was a problem hiding this comment.
What was the problem? Is it a bug or a feature? :P
There was a problem hiding this comment.
marco-c
reviewed
Nov 22, 2021
| if dup["signature"] is None: | ||
| # some bugs don't have a cf_crash_signature field... it's weird | ||
| # but it's life... | ||
| continue |
There was a problem hiding this comment.
Given that the bug is going to be fixed, let's log a warning so we don't silently ignore the problem if it reappears
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug here: https://bugzilla.mozilla.org/show_bug.cgi?id=1572618
hasn't a signature field and consequently we get some nag mails every hour...