-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add whiteboard flag to webcompat sightline bugs #2498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgraham
force-pushed
the
webcompat_sightline
branch
from
November 4, 2024 17:44
4f05ba2
to
96524e0
Compare
jgraham
changed the title
Webcompat sightline
Add whiteboard flag to webcompat sightline bugs
Nov 4, 2024
ksy36
approved these changes
Nov 5, 2024
jgraham
force-pushed
the
webcompat_sightline
branch
from
November 6, 2024 10:54
96524e0
to
8ab569c
Compare
jgraham
force-pushed
the
webcompat_sightline
branch
from
November 13, 2024 10:46
8ab569c
to
8f99de6
Compare
jgraham
force-pushed
the
webcompat_sightline
branch
from
November 14, 2024 11:59
8f99de6
to
6e290ed
Compare
This should be set on all bugs that are part of the webcompat metrics set, and by no bugs that aren't. This initial approach just gets all the bugs that are either in that set or have the whiteboard entry, and implements the logic to update them in the client. Given that we expect initially to have ~700 bugs in that set, this means we need to set the maximum number of bugs to update to something rather high.
jgraham
force-pushed
the
webcompat_sightline
branch
from
November 14, 2024 14:20
6e290ed
to
4cb9b8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! LGTM! I have only minor comments.
We need to add this new rule to the bot's wiki page before deploying the new rule.
Co-authored-by: Suhaib Mujahid <[email protected]>
suhaibmujahid
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
to-be-announced
tag added if this is worth announcing