Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whiteboard flag to webcompat sightline bugs #2498

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

jgraham
Copy link
Member

@jgraham jgraham commented Oct 11, 2024

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid self-assigned this Oct 15, 2024
@jgraham jgraham force-pushed the webcompat_sightline branch from 4f05ba2 to 96524e0 Compare November 4, 2024 17:44
@jgraham jgraham marked this pull request as ready for review November 4, 2024 17:44
@jgraham jgraham changed the title Webcompat sightline Add whiteboard flag to webcompat sightline bugs Nov 4, 2024
bugbot/gcp.py Outdated Show resolved Hide resolved
bugbot/gcp.py Outdated Show resolved Hide resolved
bugbot/gcp.py Outdated Show resolved Hide resolved
@jgraham jgraham force-pushed the webcompat_sightline branch from 96524e0 to 8ab569c Compare November 6, 2024 10:54
@jgraham jgraham requested a review from suhaibmujahid November 7, 2024 14:38
bugbot/rules/webcompat_sightline.py Outdated Show resolved Hide resolved
bugbot/rules/webcompat_sightline.py Outdated Show resolved Hide resolved
This should be set on all bugs that are part of the webcompat metrics
set, and by no bugs that aren't.

This initial approach just gets all the bugs that are either in that
set or have the whiteboard entry, and implements the logic to update
them in the client. Given that we expect initially to have ~700 bugs
in that set, this means we need to set the maximum number of bugs to
update to something rather high.
@jgraham jgraham force-pushed the webcompat_sightline branch from 6e290ed to 4cb9b8e Compare November 14, 2024 14:20
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM! I have only minor comments.

We need to add this new rule to the bot's wiki page before deploying the new rule.

bugbot/rules/webcompat_sightline.py Outdated Show resolved Hide resolved
bugbot/rules/webcompat_sightline.py Outdated Show resolved Hide resolved
scripts/cron_run_hourly.sh Outdated Show resolved Hide resolved
Copy link
Member

@suhaibmujahid suhaibmujahid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@suhaibmujahid suhaibmujahid merged commit d66e5d5 into mozilla:master Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants